Prefetch participant images fixes #311#351
Conversation
|
@Anupam-dagar @ananya-agrawal please review this pr. |
|
I'm not sure, but I think it works better in Firefox developer edition. |
|
link |
|
I'm sorry. I forget everytime 😅 |
|
@anupm12 i can't see any impovement also in firefox it's taking more time than before |
|
@prateek76 |
|
@pradeepgangwar @ananya-agrawal @prateek76 https://stackoverflow.com/questions/41655955/why-are-preload-link-not-working-for-json-requests |
|
This is my code This is what it does I don't know if this is preloading or not. |
|
@pradeepgangwar take a look at it. |
|
This is not the correct way to load image and assign. I see that in your script you are appending it in body tag. |
|
@anupm12 Sorry for delay 😅 . I got busy with other things and completely forgot about this one. Let me check this. |
4 participants
Did you read the instructions in README ?
Yes
Solves which issue ?
Fixes #311
Give discription.
Images are now being cached by the browser and the loading is comparatively faster now. All time it takes is to fetch data from json.
I have made a script to fetch the images and prefetched that script using HTML.
Checklist
(To mark the checkboxes use
xwithin the box brackets)Signed the code of conduct.
Have you added yourself to the participants.
Joined opencode zulip server.